Re: [whatwg/streams] Reject writer.ready promise on errors, instead of fulfilling (#526)

domenic commented on this pull request.



> @@ -0,0 +1,78 @@
+'use strict';
+
+if (self.importScripts) {
+  self.importScripts('/resources/testharness.js');
+  self.importScripts('../resources/test-utils.js');
+  self.importScripts('../resources/recording-streams.js');
+}
+
+const error1 = new Error('error1');
+error1.name = 'error1';
+
+promise_test(t => {
+

Personally I write the tests with blank lines after the opening brace and before the last line/description. Otherwise it's too hard to distinguish the test description from the test code. *shrug*

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/streams/pull/526

Received on Friday, 7 October 2016 18:35:36 UTC