Re: [whatwg/streams] Reject writer.ready promise on errors, instead of fulfilling (#526)

tyoshino commented on this pull request.



> +
+promise_test(t => {
+
+  const ws = recordingWritableStream({
+    write(chunk) {
+      if (ws.events.length === 2) {
+        return delay(10);
+      }
+
+      return Promise.reject(error1);
+    }
+  });
+
+  const writer = ws.getWriter();
+
+

single blank line

> @@ -473,154 +473,6 @@ test('If close is called on a WritableStream in waiting state, ready will be ful
   }, 0);
 });
 
-test('If sink rejects on a WritableStream in writable state, ready will return a fulfilled promise', t => {

you've dropped this since the "returning a rejected promise (second write)" test would cover most of this?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/streams/pull/526#pullrequestreview-3253053