- From: Matt Giuca <notifications@github.com>
- Date: Thu, 06 Oct 2016 22:33:27 -0700
- To: w3c/manifest <manifest@noreply.github.com>
Received on Friday, 7 October 2016 05:33:55 UTC
mgiuca commented on this pull request.
lgtm with additional change.
@dominickng what are your thoughts on this rename? (See #502 for the issue).
> @@ -419,37 +419,38 @@ <h3 id="installation-sec">
</p>
<pre class="idl">
partial interface Window {
- attribute EventHandler oninstall;
+ attribute EventHandler onappinstalled;
};
</pre>
<div class="example">
<p>
This example shows two ways of handling the install event.
s/install/appinstalled
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/w3c/manifest/pull/503#pullrequestreview-3246616
Received on Friday, 7 October 2016 05:33:55 UTC