- From: Takeshi Yoshino <notifications@github.com>
- Date: Wed, 05 Oct 2016 23:41:14 -0700
- To: whatwg/streams <streams@noreply.github.com>
Received on Thursday, 6 October 2016 06:41:48 UTC
tyoshino commented on this pull request.
lgtm
> +
+ let resolveStartPromise;
+ const ws = new WritableStream({
+ start() {
+ return new Promise(resolve => {
+ resolveStartPromise = resolve;
+ });
+ },
+ write() {
+ t.step(() => assert_unreached('write could not be called'));
+ },
+ close() {
+ t.step(() => {
+ assert_true(expectCloseCall, 'close should not be called until start promise resolves');
+ t.done();
+ });
indentation
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/streams/pull/525#pullrequestreview-3052844
Received on Thursday, 6 October 2016 06:41:48 UTC