Re: [w3c/push-api] Switching to contiguous webidl (#229)

beverloo commented on this pull request.



> -        </dt>
-        <dt>
-          Promise&lt;PushSubscription?&gt; getSubscription ()
-        </dt>
-        <dt>
-          Promise&lt;PushPermissionState&gt; permissionState (optional PushSubscriptionOptionsInit
-          options)
-        </dt>
-      </dl>
+      <pre class="idl">
+interface PushManager {
+    Promise&lt;PushSubscription&gt; subscribe(optional PushSubscriptionOptionsInit options);
+    Promise&lt;PushSubscription?&gt; getSubscription();
+    Promise&lt;PushPermissionState&gt; permissionState(optional PushSubscriptionOptionsInit options);
+};
+</pre>
       <p>
         The <code><dfn id=
         "widl-PushManager-subscribe-Promise-PushSubscription--PushSubscriptionOptionsInit-options">subscribe</dfn></code>

Here and elsewhere: the names of the members [aren't being linkified](https://cdn.rawgit.com/martinthomson/push-api/contiguous-webidl/index.html#extensions-to-the-serviceworkerregistration-interface) anymore. It looks like the definitions of the members need to indicate that they are, so this `<code>...</code>` should change to:

`<dfn for="PushManager" title="subscribe"><code>subscribe</code></dfn>`

(modulo #58, so in whichever order you prefer)

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/w3c/push-api/pull/229#pullrequestreview-10612741