Re: [w3c/push-api] Properly defining `pushsubscriptionchange` (#228)

This looks terrific. Passing both `oldSubscription` and `newSubscription` is nice, and avoids having the worker make an extra `subscribe()` call to get a new endpoint, or figure out if it still has permission.

Making `oldSubscription` nullable seems a little strange: the browser knows the service worker had a subscription, but can't construct a full `PushSubscription` object? The browser could resubscribe and pass `newSubscription`, but that might not be useful to the app server if it depends on knowing the old endpoint. Could we treat this similarly to #61 and not fire `pushsubscriptionchange`?

For invalidation, I agree with @johnmellor. `waitUntil` doesn't offer enough guarantees that the new subscription info made it to the app server. Using the subscription for the first time is pretty clear.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/w3c/push-api/issues/228#issuecomment-263354691