Re: [whatwg/fullscreen] Decide whether to resize synchronously in requestFullscreen() (#64)

foolip commented on this pull request.



> +     <!-- cross-process -->
+    </ul>
+
+    <p class=note>For example, <var>pending</var> may have been moved to another document,
+    <code>allowfullscreen</code> attributes may have been removed, or <var>topLevelDoc</var> may
+    have exited fullscreen since {{Element/requestFullscreen()}} was invoked.
+
+   <li>
+    <p>If <var>error</var> is true, run these subsubsteps:
+
+    <ol>
+     <li><p><a>Fire an event</a> named <code>fullscreenerror</code> on <var>pendingDoc</var>.
+
+     <li><p>Reject <var>promise</var> with a <code>TypeError</code> exception.
+
+     <li><p>Terminate these steps and run the remaining subsubsteps <a>in parallel</a>.

@annevk, help with better wording?

> +
+    <p class=note>For example, <var>pending</var> may have been moved to another document,
+    <code>allowfullscreen</code> attributes may have been removed, or <var>topLevelDoc</var> may
+    have exited fullscreen since {{Element/requestFullscreen()}} was invoked.
+
+   <li>
+    <p>If <var>error</var> is true, run these subsubsteps:
+
+    <ol>
+     <li><p><a>Fire an event</a> named <code>fullscreenerror</code> on <var>pendingDoc</var>.
+
+     <li><p>Reject <var>promise</var> with a <code>TypeError</code> exception.
+
+     <li><p>Terminate these steps and run the remaining subsubsteps <a>in parallel</a>.
+
+     <li><p>If <var>resize</var> is true, resize <var>topLevelDoc</var>'s viewport to its "normal"

This is still not quite right. There could be a fullscreen element, in which case one would also have to fiddle with the top layer. Ideas on the minimal amount of fiddling required to end up in a good state appreciated.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/fullscreen/pull/64#pullrequestreview-10178809