- From: Adam Rice <notifications@github.com>
- Date: Thu, 24 Nov 2016 23:56:59 -0800
- To: whatwg/streams <streams@noreply.github.com>
Received on Friday, 25 November 2016 07:57:37 UTC
When writer.releaseLock() was called during us.close(), an assert would fire in WritableStreamFinishClose() as it expected the writer to still be attached. Since detaching the writer during close() is permitted, remove the assert. Also add tests that this works correctly. You can view, comment on, or merge this pull request online at: https://github.com/whatwg/streams/pull/621 -- Commit Summary -- * Verify that releaseLock() during close() works * Do not assert() when writer is detached during close() -- File Changes -- M reference-implementation/lib/writable-stream.js (4) M reference-implementation/to-upstream-wpts/writable-streams/close.js (32) -- Patch Links -- https://github.com/whatwg/streams/pull/621.patch https://github.com/whatwg/streams/pull/621.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/whatwg/streams/pull/621
Received on Friday, 25 November 2016 07:57:37 UTC