Re: [whatwg/streams] Aborting a stream should wait for pending writes (#619)

ricea commented on this pull request.



> +    writer.abort(new Error());
+    let closedResolved = false;
+    return Promise.all([
+      promise_rejects(t, new Error(), writePromise, 'write() should reject')
+          .then(() => assert_false(closedResolved, '.closed should not resolve before write()')),
+      promise_rejects(t, new TypeError(), writer.closed, '.closed should reject')
+          .then(() => {
+            closedResolved = true;
+          })]);
+  });
+}, '.closed should not resolve before rejected write()');
+
+promise_test(t => {
+  const ws = new WritableStream({
+    write() {
+      return delay(0);

Based on the assumption that abort() is synchronous, delay(0) is sufficient. However, that assumption was bogus anyway, so I've switched to flushAsyncEvents().

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/streams/pull/619