Re: [whatwg/streams] Aborting a writable stream should not abort writes in progress (#611)

> If the resource is invalid, it aborts, truncates the file to where it was to start with, and retries. It looks like this:

Great example for analysis. But the promise returned by the `pipeTo()` call rejects after `underlyingSink.abort()` fulfills. So, this issue could be addressed by delaying the fulfillment.

That said, we can say the same for `.closed`. We cannot determine the timing when we can perform an operation like `truncateFileAndRetry` by `.closed` without the proposed change.

> Since they can easily implement this themselves by calling abort() and setting some flag to disregard any promises that settle after that point, I don't see this as a significant problem.

Agreed. I also quickly looked for any use case where `.closed` is expected to be rejected immediately, but I don't see anything.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/streams/issues/611#issuecomment-262690445