Re: [whatwg/streams] Invoking methods should not call .apply() (#613)

tyoshino commented on this pull request.



> @@ -58,7 +62,7 @@ exports.InvokeOrNoop = (O, P, args) => {
     throw new TypeError(`${P} is not a function`);
   }
 
-  return method.apply(O, args);
+  return Call(method, O, args);

It seems including the L61-63 in the Call method you've just introduced would give them better correspondence because the lines are performing the step `If IsCallable(F) is false, throw a TypeError exception.` of the Call operation ( https://tc39.github.io/ecma262/#sec-call ).

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/streams/pull/613#pullrequestreview-8745440

Received on Wednesday, 16 November 2016 03:47:05 UTC