- From: Adam Rice <notifications@github.com>
- Date: Mon, 14 Nov 2016 18:42:50 -0800
- To: whatwg/streams <streams@noreply.github.com>
Received on Tuesday, 15 November 2016 02:43:21 UTC
ricea commented on this pull request. > @@ -826,7 +826,7 @@ noticable asymmetry between the two branches. [[!HTML]] 1. Set _pull_.[[branch1]] to _branch1Stream_.[[readableStreamController]]. 1. Set _pull_.[[branch2]] to _branch2Stream_.[[readableStreamController]]. 1. <a>Upon rejection</a> of _reader_.[[closedPromise]] with reason _r_, - 1. If _teeState_.[[closedOrErrored]] is *true*, return *undefined*. + 1. If _teeState_.[[closedOrErrored]] is *true*, return. I feel that this one should be return *undefined*, since ReadableStreamTee does sometimes return a defined value. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/whatwg/streams/pull/612#pullrequestreview-8528628
Received on Tuesday, 15 November 2016 02:43:21 UTC