Re: [heycam/webidl] Refactor integer conversion in ES bindings. (#235)

annevk commented on this pull request.

Found some minor nits. Bit late.

> +    represents the closest numeric value to the {{unsigned long long}},
+    choosing the numeric value with an <em>even significand</em> if there are
+    two [=equally close values=].
+    If the {{unsigned long long}} is less than or equal to 2<sup>53</sup> − 1,
+    then the <emu-val>Number</emu-val> will be able to
+    represent exactly the same value as the
+    {{unsigned long long}}.
+</p>
+
+<h5 id="es-integer-types-abstract-ops">Abstract operations</h5>
+
+<div algorithm>
+
+    <dfn lt="IntegerPart" abstract-op>IntegerPart(|n|)</dfn>:
+
+    1.  Let |r| be [=floor=]([=abs=](|n|))

Misses a dot.

> +    {{unsigned long long}}.
+</p>
+
+<h5 id="es-integer-types-abstract-ops">Abstract operations</h5>
+
+<div algorithm>
+
+    <dfn lt="IntegerPart" abstract-op>IntegerPart(|n|)</dfn>:
+
+    1.  Let |r| be [=floor=]([=abs=](|n|))
+    1.  If |n| &lt; 0, then return -1 × |r|.
+    1.  Otherwise, return |r|.
+</div>
+
+<div algorithm>
+    <dfn lt="ConvertToInt" abstract-op>ConvertToInt(|V|, |bitLength|, |signedness|)</dfn>:

Previous alg had a newline following it.

> @@ -6969,9 +6850,9 @@ may return any value, which will be discarded.
     An ECMAScript value |V| is [=converted to an IDL value|converted=]
     to an IDL {{float}} value by running the following algorithm:
 
-    1.  Let |x| be [=ToNumber=](|V|).
-    1.  If |x| is <emu-val>NaN</emu-val>, <emu-val>+Infinity</emu-val> or
-        <emu-val>−Infinity</emu-val>, then <a lt="es throw">throw a <emu-val>TypeError</emu-val></a>.
+    1.  Let |x| be [=?=] [=ToNumber=](|V|).
+    1.  If |x| is <emu-val>NaN</emu-val>, +∞, or −∞,
+         then <a lt="es throw">throw a <emu-val>TypeError</emu-val></a>.

Indentation is off.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/heycam/webidl/pull/235#pullrequestreview-8293753