Re: [whatwg/xhr] Convert XHR to bikeshed (#97)

> probably due to append() being an overloaded method. 

Yup, that's the problem here.  Bikeshed uses argument names, not types, in its signatures, so if you have overloads that use the same name and have the same shape, it'll be a problem. (This has the same shape because, to help with human usability, it registers variants that omit the optional args too, so the Blob overload has both a 3-arg and 2-arg version, and the 2-arg looks exactly like the USVString overload.)

I'm not 100% sure how I would fix this on the Bikeshed side; it might not really be possible without adding some new concepts to allow disambiguation.  Easy to fix on the source side by just using a different argument name for one of the required args (presumably the second arg, as it's the one that varies).

> I also get duplicate ID warnings I cannot figure out. (Maybe in part because nothing is generating yet.)

Remember you can force-generate with `bikeshed -f spec`! That way you can see what the output is and figure out what's going wrong.  In this case, the issue is that you have a bunch of things like:

```
The
<dfn lt="dom XMLHttpRequest upload"><code>upload</code></dfn>
attribute
```
(line 724-726)

which *attempt* to define the upload attribute of XMLHttpRequest, but aren't marked up properly to do so, and which happen to generate the exact same automatic ID as the dfn in the WebIDL block.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/xhr/pull/97#issuecomment-259263761

Received on Tuesday, 8 November 2016 21:23:34 UTC