Re: [w3c/manifest] feat: add AppBannerPromptOutcome enum (#519)

mgiuca commented on this pull request.



> +            "dismissed"
+          };
+        </pre>
+        <p>
+          The <dfn>AppBannerPromptOutcome</dfn> enum's values represent the
+          outcomes from <a data-lt="presents an install prompt">presenting the
+          end-user with an install prompt</a>.
+        </p>
+        <dl data-dfn-for="AppBannerPromptOutcome">
+          <dt>
+            <dfn>accepted</dfn>:
+          </dt>
+          <dd>
+            The end-user indicated that they would like the user agent to
+            <a>install</a> the web application.
+            <p class="note">

In the same spirit as my comments yesterday, I don't think this note is necessary. It's not an instruction, it's an enum value indicating a user choice. There should be no misapprehension that this implies success.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/w3c/manifest/pull/519#pullrequestreview-7545811