Re: [w3c/manifest] feat: add AppBannerPromptOutcome enum (#519)

mgiuca commented on this pull request.



> +          enum AppBannerPromptOutcome {
+            "accepted",
+            "dismissed"
+          };
+        </pre>
+        <p>
+          The <dfn>AppBannerPromptOutcome</dfn> enum's values represent the
+          outcomes from <a data-lt="presents an install prompt">presenting the
+          end-user with an install prompt</a>.
+        </p>
+        <dl data-dfn-for="AppBannerPromptOutcome">
+          <dt>
+            <dfn>accepted</dfn>:
+          </dt>
+          <dd>
+            The end-user indicated that the user agent MUST attempt to

This wording is a little strange. "The end-user indicated that <X>." This doesn't exactly convey that X should happen, since it's qualified by "the end-user indicated that". I don't think you should be mandating *what* the UA should do here; these are enum values after all, not algorithms. You should just describe what the enum represents (i.e., "The end-user indicated that they would like to install the web application.") Save the instruction for the UA for the "steps to install a web application" algorithm.

> +          <dt>
+            <dfn>accepted</dfn>:
+          </dt>
+          <dd>
+            The end-user indicated that the user agent MUST attempt to
+            <a>install</a> the web application.
+            <p class="note">
+              This does not necessarily mean that the <a>installation
+              process</a> will <a data-lt="installation succeeded">succeed</a>.
+            </p>
+          </dd>
+          <dt>
+            <dfn>dismissed</dfn>:
+          </dt>
+          <dd>
+            The end-user dismissed the install prompt, thus the user agent MUST

Similarly, it doesn't make sense to dictate what the UA MUST do here, since it is an enum value. Just "The end-user dismissed the install prompt."

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/w3c/manifest/pull/519#pullrequestreview-7360794