Re: [whatwg/streams] add "bytes" readableType to TransformStream transformer (#601)

ricea commented on this pull request.

I don't understand the benefit of adding byte stream support on the readable side when we don't yet have it on the writable side. So I will leave this for @domenic or @tyoshino to review, as they are better qualified to comment on the impact of this change.

> @@ -379,23 +435,26 @@ class TransformStream {
 
     this._transformStreamController = new TransformStreamDefaultController(this);
 
+    this._readableType = transformer.readableType;

Is there a reason not to validate the value of `readableType` and `writableType` here? It seems weird to me.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/streams/pull/601#pullrequestreview-7316417