- From: Adam Rice <notifications@github.com>
- Date: Thu, 03 Nov 2016 08:40:19 -0700
- To: whatwg/streams <streams@noreply.github.com>
- Message-ID: <whatwg/streams/pull/594/review/7034823@github.com>
ricea commented on this pull request. lgtm with nits > @@ -0,0 +1,14 @@ +<!DOCTYPE html> +<meta charset="utf-8"> +<script src="/resources/testharness.js"></script> +<script src="/resources/testharnessreport.js"></script> +<script src="/service-workers/service-worker/resources/test-helpers.sub.js"></script> +<script src="/streams/resources/test-initializer.js"></script> Can you make this `"../resources/test-initializer.js"` for consistency with the other tests? > @@ -0,0 +1,14 @@ +<!DOCTYPE html> +<meta charset="utf-8"> +<script src="/resources/testharness.js"></script> +<script src="/resources/testharnessreport.js"></script> +<script src="/service-workers/service-worker/resources/test-helpers.sub.js"></script> +<script src="/streams/resources/test-initializer.js"></script> + +<style src="/resources/testharness.css"></style> Is this needed? The other test files don't have it. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/whatwg/streams/pull/594#pullrequestreview-7034823
Received on Thursday, 3 November 2016 15:41:00 UTC