[whatwg/streams] sync spec and implementation of autoAllocateChunkSize (#592)

autoAllocateSize was added in #430 as commit e601d69f3ba40e6f4b5506e4bb1fbe3f3eabf393.

The spec was out of sync with the reference implementation: it tried to round
non-integers into integers instead of rejecting them.

The reference implementation was out of sync with the spec: it was allowing
an autoAllocateChunkSize of 0 through instead of throwing a RangeError.

The toInteger helper was added in 200b54bbbce02d7f6690e40510bf6bee4ff8b7c6
and its only user was removed in commit 5b47faa994139c3c68bb462920f58a29372f6784.

I'm not sure where to add readable-stream tests, but there probably should be one for rejecting `autoAllocateChunkSize: 0`.
You can view, comment on, or merge this pull request online at:

  https://github.com/whatwg/streams/pull/592

-- Commit Summary --

  * sync spec and implementation of autoAllocateChunkSize

-- File Changes --

    M index.bs (3)
    M reference-implementation/lib/helpers.js (13)
    M reference-implementation/lib/readable-stream.js (2)

-- Patch Links --

https://github.com/whatwg/streams/pull/592.patch
https://github.com/whatwg/streams/pull/592.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/streams/pull/592

Received on Thursday, 3 November 2016 03:33:23 UTC