Re: [whatwg/streams] Consider adding type assertions for all abstract operations (#453)

So I started looking into this and it basically amounts to the following:

- Every time an abstract operation (in section 3) has an argument named "stream", add "Assert: ! IsReadableStream(_stream_) is **true**."
- Every time an abstract operation in section 3.9 has an argument named "controller", add "Assert: ! IsReadableStreamDefaultController(_controller_) is **true**."
- Every time an abstract operation in section 3.12 has an argument named "controller", add "Assert: ! IsReadableStreamBYOBController(_controller_) is **true**."
- Every time an abstract operation in section 3.7 has an argument named "reader", add one of the two asserts depending on the reader type, or assert that either type is allowed.

I'm not really convinced this is valuable. Currently I have assertions in most of the algorithms that are intended to be called from other specs, to make sure other specs are clear on the requirements they need to set up before calling into this one. But within this spec, I don't think they add any more useful documentation beyond that already present by virtue of the parameter name or abstract operation name.

What do you guys think?

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/streams/issues/453#issuecomment-222208552