Re: [whatwg/streams] Mostly-editorial tweaks to align with newer ES algorithm styles (#444)

> @@ -19,6 +19,9 @@ wptRunner(testsPath, setup)
>    });
>  
>  function setup(window) {
> +  // Necessary so that we can send test-realm promises to the jsdom-realm implementation without causing assimilation.
> +  window.Promise = Promise;

Mehh. wpt-runner is kind of a giant hack, so it might not be worth your time.

It basically creates a whole nother global environment in which to run its scripts, including new values for Promise, Map, Set, Number, etc. This usually isn't a problem, but for promises it causes problems now that V8 has updated their promise-detection code.

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/streams/pull/444/files/1c563fab0411f262c15ffcf9b56b829ca9548247#r62339771

Received on Friday, 6 May 2016 14:50:41 UTC