- From: Marijn Kruisselbrink <notifications@github.com>
- Date: Wed, 16 Mar 2016 12:57:13 -0700
- To: slightlyoff/ServiceWorker <ServiceWorker@noreply.github.com>
- Message-ID: <slightlyoff/ServiceWorker/issues/849/197518392@github.com>
Yeah, the job's client was used in a few more places (by associating it with `ServiceWorker` and `ServiceWorkerRegistation` instances), but I removed those in 08a506e9d5a25bc18dd6d16c1dfb11ef6a8914d2 because those client associations weren't actually needed. So a possible solution for this bug could indeed be to just get rid of the client of a job entirely. I wonder if current implementations use the client as referrer of requests to fetch a serviceworker, or if this something where implementations already don't follow the spec (looking at the chrome implementation I don't think we use the client as referrer anywhere). If spec already don't set the referrer of these requests to the client who called register/update, I don't see any reason not to make the spec match the implementations, and get rid of the client in jobs/updating entirely. Of course we'd then still need a way to pass a module map to "fetch a module script tree" separate from the (possibly null) settings object, or create a dummy settings object just for the purpose of fetching updates. --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/slightlyoff/ServiceWorker/issues/849#issuecomment-197518392
Received on Wednesday, 16 March 2016 19:57:44 UTC