- From: Domenic Denicola <notifications@github.com>
- Date: Thu, 29 Dec 2016 08:21:01 -0800
- To: whatwg/url <url@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Thursday, 29 December 2016 16:22:21 UTC
domenic commented on this pull request. > @@ -2067,16 +2056,15 @@ then runs these steps: <li><p>Append "<code>//</code>" to <var>output</var>. <li> - <p>If <var>url</var>'s <a for=url>username</a> is not the empty string - or <var>url</var>'s <a for=url>password</a> is non-null, run these substeps: + <p>If <var>url</var>'s <a for=url>username</a> or <a for=url>password</a> is not + the empty string, then: This could probably use the "includes credentials" concept? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/whatwg/url/pull/186#pullrequestreview-14683815
Received on Thursday, 29 December 2016 16:22:21 UTC