- From: achristensen07 <notifications@github.com>
- Date: Wed, 28 Dec 2016 09:35:28 -0800
- To: whatwg/url <url@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Wednesday, 28 December 2016 17:36:04 UTC
Seems good. Make sure to add a test verifying something like "new URL('path', 'asdf://host')" serializes to 'asdf://host/path' adding the slash. I broke something by forgetting that in my initial implementation. I don't add a slash for query-only or fragment-only relative URLs, but that might be worth more discussion. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/whatwg/url/pull/185#issuecomment-269511220
Received on Wednesday, 28 December 2016 17:36:04 UTC