- From: Jungkee Song <notifications@github.com>
- Date: Fri, 16 Dec 2016 06:01:51 -0800
- To: w3c/ServiceWorker <ServiceWorker@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Friday, 16 December 2016 14:02:34 UTC
@jakearchibald, LGTM with the following points! * https://github.com/w3c/ServiceWorker/pull/983/files#diff-27b79860afe28f01aed4f1f6228367faR2853 - It seems the comment for this line hasn't been addressed yet * https://github.com/w3c/ServiceWorker/pull/983/files/1e58712f505366a5c260213e297d1ead43f5874a..245b62e45dc0cef0d2f30e6fb1fdec9b1fbc7c4b#diff-27b79860afe28f01aed4f1f6228367faR2855 - Maybe you can land this with https://github.com/whatwg/fetch/pull/435 (to reference service-workers mode.) Or just keep the current text (skip-service-worker flag) for this PR and change this line in https://github.com/w3c/ServiceWorker/pull/1025. Please include the corresponding html file when you merge it. Thank you! -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/w3c/ServiceWorker/pull/983#issuecomment-267600111
Received on Friday, 16 December 2016 14:02:34 UTC