Re: [w3c/ServiceWorker] Opt cache.add/addAll and importScripts out of a local service worker (#1025)

jungkees commented on this pull request.

Would like to check if you wanted to introduce a new flag.

> @@ -1862,6 +1862,7 @@ spec: webappsec-referrer-policy; urlPrefix: https://w3c.github.io/webappsec-refe
             1. If |r|'s [=request/url=]'s [=url/scheme=] is not one of "<code>http</code>" and "<code>https</code>", then:
                 1. [=fetch/Terminate=] all the ongoing <a>fetches</a> initiated by |requests| with reason *fatal*.
                 1. Break the loop.
+            1. If |r|'s [=request/client=]'s [=environment settings object/global object=] is a {{ServiceWorkerGlobalScope}} object, set |request|'s [=skip-local-service-worker flag=].

Are you introducing a new flag here? Or did you intend to use _skip-service-worker flag_?

> @@ -2152,6 +2153,7 @@ spec: webappsec-referrer-policy; urlPrefix: https://w3c.github.io/webappsec-refe
         1. Let |serviceWorker| be |request|'s [=request/client=]'s [=environment settings object/global object=]'s [=ServiceWorkerGlobalScope/service worker=].
         1. If |serviceWorker|'s <a>imported scripts updated flag</a> is unset, then:
             1. Let |registration| be |serviceWorker|'s [=containing service worker registration=].
+            1. Set |request|'s [=skip-local-service-worker flag=].

Same as above.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/w3c/ServiceWorker/pull/1025#pullrequestreview-13074924