- From: Philip Jägenstedt <notifications@github.com>
- Date: Wed, 14 Dec 2016 15:27:40 -0800
- To: whatwg/fullscreen <fullscreen@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Wednesday, 14 December 2016 23:28:12 UTC
This is also from https://codereview.chromium.org/2573773002/ where things just seemed to be complicated if it's possible to have no fullscreen element and trying to exit anyway, but I'm quite uncertain about the fix and would like feedback. Another way would be to keep track of the original (potentially null) fullscreen element as *pending* and checking if it has changed, but I'd prefer not as exiting now doesn't need to keep track of any element at all. Together with #65, multiple calls to `exitFullscreen()` would at most behave as `exitFullscreen({ fully: true })` so maybe this is good enough. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/whatwg/fullscreen/pull/66#issuecomment-267189420
Received on Wednesday, 14 December 2016 23:28:12 UTC