Re: [w3c/manifest] Add support for 'serviceworkers' member (#507)

jungkees commented on this pull request.



> +          </li>
+          <li>If <var>src</var> is <code>undefined</code>, or if the result of
+          running <a>Is origin potentially trustworthy</a>
+          with the origin of <var>src</var> is <code>Not Trusted</code>, abort
+          these steps and return <code>undefined</code>.
+          </li>
+          <li>Otherwise, let <var>registration</var> be an object with
+          properties <code>src</code>, <code>scope</code>, <code>type</code> and
+          <code>use_cache</code>. All properties initially set to
+          <code>undefined</code>.
+          </li>
+          <li>Set <var>registration</var>'s <code>src</code> property to be
+          <var>src</var>.
+          </li>
+          <li>Let <var>scope</var> be the result of running the <a>steps
+          for processing the <code>scope</code> member of a service worker</a>

When this algorithm returns _undefined_, the _steps to install the web application_ gets to pass nothing to Start Register. In this case, shouldn't there be an error handling such that Start Register is not invoked?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/w3c/manifest/pull/507#pullrequestreview-12922790