Re: [w3c/manifest] Add support for 'serviceworkers' member (#507)

jungkees requested changes on this pull request.

Service workers expect default values from scope, type, and use_cache members. Please see the comments.

>            for processing the <code>scope</code> member of a service worker</a>
           passing <var>unprocessed registration</var>.
           </li>
           <li>If <var>scope</var> is not <code>undefined</code>,
           set <var>registration</var>'s <code>scope</code>
           property to be <var>scope</var>.
           </li>
+          <li>Let <var>type</var> be the result of running the <a>steps
+          for processing the <code>type</code> member of a service worker</a>
+          passing <var>unprocessed registration</var>.
+          </li>
+          <li>If <var>type</var> is not <code>undefined</code>
+          set <var>registration</var>'s <code>type</code>
+          property to be <var>type</var>.
+          </li>
+          <li>If <var>type</var> is <code>undefined</code> abort these steps and
+          return <code>undefined</code>.

Service workers expect a default value for type member. If type is undefined here, please set the default value to "classic" when passing it to Start Register.

> +          set <var>registration</var>'s <code>type</code>
+          property to be <var>type</var>.
+          </li>
+          <li>If <var>type</var> is <code>undefined</code> abort these steps and
+          return <code>undefined</code>.
+          </li>
+          <li>Let <var>use cache</var> be the result of running the <a>steps
+          for processing the <code>use_cache</code> member of a service worker</a>
+          passing <var>unprocessed registration</var>.
+          </li>
+          <li>If <var>use cache</var> is not <code>undefined</code>,
+          set <var>registration</var>'s <code>use_cache</code>
+          property to be <var>use cache</var>.
+          </li>
+          <li>If <var>use cache</var> is <code>undefined</code> abort these steps
+          and return <code>undefined</code>.

Likewise, If use_cache is undefined here, please set the default value to false when passing it to Start Register.

* Note that there's an ongoing discussion about the expected default behavior in https://github.com/w3c/ServiceWorker/issues/893. So, there's a chance SW may require true as default depending on the discussion there.

>            </li>
           <li>Set <var>registration</var>'s <code>src</code> property to be
           <var>src</var>.
           </li>
-          <li>Let <var>type</var> be the result of running the <a>steps
+          <li>Let <var>scope</var> be the result of running the <a>steps

Similar to type and use_cache, SW expects a default value for scope too. If scope is undefined, please give null to Start Register as a default value. That makes Start Register set the scope to the same location as the given script url.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/w3c/manifest/pull/507#pullrequestreview-12836454