- From: isonmad <notifications@github.com>
- Date: Thu, 08 Dec 2016 18:31:08 -0800
- To: whatwg/streams <streams@noreply.github.com>
- Message-ID: <whatwg/streams/pull/623/review/12160496@github.com>
isonmad commented on this pull request. > @@ -1447,6 +1478,12 @@ Instances of {{ReadableStreamDefaultController}} are created with the internal s </tr> </thead> <tr> + <td>\[[targetRealm]] This approach just seemed intuitive to me. - For one, I wanted to make throw-on-enqueue possible, so the clone call has to occur when a chunk first enters the controller's queue, not when it leaves it, as would happen in your algorithm. - The underlyingSource still lives in the original realm, and has a reference to the controller object. (Conceptually, 'controller' is sort of a term for two different things that are conflated, a public API object provided to the underlyingSource and the hidden implementation details of the stream. The API object is stuck in the original realm of the underlyingSource, but the 'implementation details' of the stream are in charge of moving things between realms, and I was conceiving that as synonymous with a single controller, I guess.) - I thought it would also be nice to have a stream that clones its chunks *without* having to transfer it to a worker and back again, and there's no need for a second readablestream at all in that case. - It just seems like less code. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/whatwg/streams/pull/623
Received on Friday, 9 December 2016 02:31:41 UTC