Re: [heycam/webidl] Add missing legacy error names. (#251)

domenic approved this pull request.



> @@ -4687,15 +4687,45 @@ Note: If an error name is not listed here, please file a bug as indicated at the
         <tbody>
             <tr>
                 <td>
-                    "<dfn id="invalidaccesserror" exception export><code>InvalidAccessError</code></dfn>"<br>
-                    <dfn id="dom-domexception-invalid_access_err" for="DOMException" const export><code>INVALID_ACCESS_ERR</code></dfn>&nbsp;(15)
+                    "<dfn id="domstringsizeerror" exception><code>DOMStringSizeError</code></dfn>"<br>
+                    <dfn id="dom-domexception-domstring_size_err" for="DOMException" const><code>DOMSTRING_SIZE_ERR</code></dfn>&nbsp;(2)
+                </td>
+                <td>Use <emu-val>RangeError</emu-val> instead.</td>

Nit: the InvalidAccessError row doesn't have "instead", so I'd say either include it everywhere or nowhere.

>                  </td>
                 <td>
                     Use <emu-val>TypeError</emu-val> for invalid arguments,
                     "{{NotSupportedError!!exception}}" for unsupported operations, and
                     "{{NotAllowedError!!exception}}" for denied requests.
                 </td>
             </tr>
+            <tr>
+                <td>
+                    "<dfn id="validationerror" exception><code>ValidationError</code></dfn>"<br>
+                    <dfn id="dom-domexception-validation_err" for="DOMException" const><code>VALIDATION_ERR</code></dfn>&nbsp;(16)
+                </td>
+                <td>—</td>
+            </tr>
+            <tr>
+                <td>
+                    "<dfn id="typemismatcherror" exception><code>TypeMismatchError</code></dfn>"<br>
+                    <dfn id="dom-domexception-type_mismatch_err" for="DOMException" const><code>TYPE_MISMATCH_ERR</code></dfn>&nbsp;(17)
+                </td>
+                <td>
+                    Use <emu-val>TypeError</emu-val> instead.
+                </td>

They're in a rather orange section: https://cdn.rawgit.com/tobie/webidl/24a82b2/index.html#domstringsizeerror

> @@ -4687,15 +4687,45 @@ Note: If an error name is not listed here, please file a bug as indicated at the
         <tbody>
             <tr>
                 <td>
-                    "<dfn id="invalidaccesserror" exception export><code>InvalidAccessError</code></dfn>"<br>
-                    <dfn id="dom-domexception-invalid_access_err" for="DOMException" const export><code>INVALID_ACCESS_ERR</code></dfn>&nbsp;(15)
+                    "<dfn id="domstringsizeerror" exception><code>DOMStringSizeError</code></dfn>"<br>
+                    <dfn id="dom-domexception-domstring_size_err" for="DOMException" const><code>DOMSTRING_SIZE_ERR</code></dfn>&nbsp;(2)
+                </td>
+                <td>Use <emu-val>RangeError</emu-val> instead.</td>
+            </tr>
+            <tr>
+                <td>
+                    "<dfn id="nodataallowederror" exception><code>NoDataAllowedError</code></dfn>"<br>
+                    <dfn id="dom-domexception-no_data_allowed_err" for="DOMException" const><code>NO_DATA_ALLOWED_ERR</code></dfn>&nbsp;(6)
+                </td>
+                <td>—</td>

I was going to suggest giving alternatives, but I don't know what these were used for once upon a time, so I'd just be guessing. So leaving with --- seems fine.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/heycam/webidl/pull/251#pullrequestreview-12092695