Re: [heycam/webidl] Deprecate InvalidAccessError. (#246)

domenic approved this pull request.

Looks good with some nits. Yay, been wanting this to happen for a while.

>              <td>"<dfn id="notallowederror" exception export><code>NotAllowedError</code></dfn>"</td>
             <td>The request is not allowed by the user agent or the platform in the current context, possibly because the user denied permission.</td>
             <td>—</td>
         </tr>
     </tbody>
 </table>
 
+<div class=advisement>
+    Additionally, the following error names are kept for legacy reasons but their usage is discouraged:
+
+    <table id="legacy-error-names" class="vert data">
+        <thead>
+            <tr>
+                <th>Name</th>

This contains more than just the name; it contains the legacy code name and value too. Maybe something more generic like "Error"

> +    <table id="legacy-error-names" class="vert data">
+        <thead>
+            <tr>
+                <th>Name</th>
+                <th>Alternative</th>
+            </tr>
+        </thead>
+        <tbody>
+            <tr>
+                <td>
+                    "<dfn id="invalidaccesserror" exception export><code>InvalidAccessError</code></dfn>"<br>
+                    <dfn id="dom-domexception-invalid_access_err" for="DOMException" const export><code>INVALID_ACCESS_ERR</code></dfn>&nbsp;(15)
+                </td>
+                <td>
+                    Use <emu-val>TypeError</emu-val> for invalid arguments and
+                    {{NotSupportedError}} for unsupported operations instead.

Maybe also mention NotAllowedError

> +    <table id="legacy-error-names" class="vert data">
+        <thead>
+            <tr>
+                <th>Name</th>
+                <th>Alternative</th>
+            </tr>
+        </thead>
+        <tbody>
+            <tr>
+                <td>
+                    "<dfn id="invalidaccesserror" exception export><code>InvalidAccessError</code></dfn>"<br>
+                    <dfn id="dom-domexception-invalid_access_err" for="DOMException" const export><code>INVALID_ACCESS_ERR</code></dfn>&nbsp;(15)
+                </td>
+                <td>
+                    Use <emu-val>TypeError</emu-val> for invalid arguments and
+                    {{NotSupportedError}} for unsupported operations instead.

Probably want quotes around NotSupportedError. Maybe even `the "NotSupportedError" DOMException` 

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/heycam/webidl/pull/246#pullrequestreview-11927113