- From: Marcos Cáceres <notifications@github.com>
- Date: Tue, 06 Dec 2016 15:54:31 -0800
- To: w3c/push-api <push-api@noreply.github.com>
- Message-ID: <w3c/push-api/pull/229/review/11710125@github.com>
marcoscaceres commented on this pull request. > - </dt> - <dt> - Promise<PushSubscription?> getSubscription () - </dt> - <dt> - Promise<PushPermissionState> permissionState (optional PushSubscriptionOptionsInit - options) - </dt> - </dl> + <pre class="idl"> +interface PushManager { + Promise<PushSubscription> subscribe(optional PushSubscriptionOptionsInit options); + Promise<PushSubscription?> getSubscription(); + Promise<PushPermissionState> permissionState(optional PushSubscriptionOptionsInit options); +}; +</pre> <p> The <code><dfn id= "widl-PushManager-subscribe-Promise-PushSubscription--PushSubscriptionOptionsInit-options">subscribe</dfn></code> This suggestion not not quite correct. You need to add `data-dfn-for="NameOfInterface"` on the section element. Again, let's just merge this an I can fix it all up. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/w3c/push-api/pull/229
Received on Tuesday, 6 December 2016 23:55:06 UTC