- From: David Baron <notifications@github.com>
- Date: Tue, 30 Aug 2016 15:42:43 -0700
- To: w3ctag/spec-reviews <spec-reviews@noreply.github.com>
- Message-ID: <w3ctag/spec-reviews/issues/128/243604903@github.com>
OK, I read through the spec and filed a bunch of issues (see above). I think the one other thing I'm concerned about is whether the names of the properties on the VisualViewport interface make sense. They're certainly a hodgepodge of things from other places in the platform (Element and MouseEvent), although I'm not aware of <code>scale</code> occuring elsewhere as a property (but see Window.devicePixelRatio). It's not obvious to me that, put together, they really make sense as an API. Perhaps some diagrams would help. But on the flip side, it's not clear to me what the relative values of having (1) a sensible API, locally vs. (2) an API whose names share meaning with names elsewhere in the platform are. On the flip side, it's also not clear to me how solid the analogies are between these properties and the correspondingly-named ones on Element and MouseEvent. I don't have any suggestions on the topic immediately, but it might be worth a little more discussion. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/w3ctag/spec-reviews/issues/128#issuecomment-243604903
Received on Tuesday, 30 August 2016 22:43:27 UTC