Re: [whatwg/dom] Further Attr node fixes for compareDocumentPosition() (#312)

>  
>      <ol>
>       <li>
> -      <p>For each <a>attribute</a> <var>node2Attribute</var> in <var>attr2</var>'s
> -      <a for=Attr>element</a>'s <a for=Element>attribute list</a>:
> +      <p>For each <a>attribute</a> <var>node2Attr</var> in <var>node2</var>'s

Segfault, here it's possible for node1 and node2 to both be null while attr1 is non-null. I think the check needs to be "If node1 and attr1 are non-null and node1 is node2" or similar, i.e. add a null-check for node2.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/dom/pull/312/files/fa39e5ce4fd80d6e5e2ed1522ce7b0769a2a37d1#r76768321