- From: Henri Sivonen <notifications@github.com>
- Date: Mon, 22 Aug 2016 10:40:00 -0700
- To: whatwg/encoding <encoding@noreply.github.com>
- Message-ID: <whatwg/encoding/issues/70@github.com>
I've written "The name of an encoding is also one of its labels, except in the case of the replacement encoding whose name is not one of its labels." inconveniently many times when either [documenting code that implements the Encoding Standard](https://hsivonen.fi/rs/encoding_rs/struct.Encoding.html) or when [otherwise explaining the concepts](https://bugzilla.mozilla.org/show_bug.cgi?id=1191841#c15). Also, I've written code that does something like "if input string is 'replacement', don't run _get an encoding_, otherwise, run _get an encoding_" when working with [interfaces](https://dxr.mozilla.org/mozilla-central/source/intl/uconv/nsScriptableUConv.cpp#270) [that](https://dxr.mozilla.org/mozilla-central/source/netwerk/base/nsUnicharStreamLoader.cpp#177) [were](https://dxr.mozilla.org/mozilla-central/source/netwerk/base/nsStandardURL.cpp#221) [designed](https://hg.mozilla.org/integration/mozilla-inbound/rev/e07157e29deedd1b2bda60c62f307503c558844f) (four links there, but GitHub's styling makes it unobvious) before there was clarity of what strings are _labels_ and what strings are _names_ used where an enum value or a reference to a singleton object representing an encoding would be more appropriate software design (when those interfaces potentially have callers in add-ons that I can't fix). All this would become simpler if _get an encoding_ for the _name_ of an encoding always returned the encoding itself. However, it's kinda sad to expose another Web-exposed label just to make implementing and explaining stuff easier, so I'm not sure if I should request this. But at least this deserves some discussion. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/whatwg/encoding/issues/70
Received on Monday, 22 August 2016 17:40:47 UTC