- From: Arthur Stolyar <notifications@github.com>
- Date: Sat, 20 Aug 2016 02:32:08 -0700
- To: slightlyoff/ServiceWorker <ServiceWorker@noreply.github.com>
Received on Saturday, 20 August 2016 09:32:37 UTC
Okay, I improved the example again and put it to a gist: https://gist.github.com/NekR/d2d70f4e34d8829ea3c078456351ddce Some notes: I do always use `self.requests` and only then use `self.caches` to check for requests. This is because I defined that `self.requests.putUntil()` holds the requests until promise settles, which might be wrong and probably it may hold the request until SW is destroyed (or request manually removed). So in current situation, if I do `self.caches` check first, I potentially may have a race when after `self.caches` check request was removed from the `self.requests` and I missed it from both places. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/slightlyoff/ServiceWorker/issues/920#issuecomment-241189732
Received on Saturday, 20 August 2016 09:32:37 UTC