- From: Gabriel Wicke <notifications@github.com>
- Date: Tue, 02 Aug 2016 23:28:42 -0700
- To: whatwg/streams <streams@noreply.github.com>
Received on Wednesday, 3 August 2016 06:29:59 UTC
@domenic, while I agree that this is a reference implementation & exact semantics should trump performance, I am not sure that there *is* actually a change in semantics here.
- My understanding of those `Object.defineProperty ` calls is that since they don't actually deviate from regular property settings (enumerable / writable / configurable), they are semantically identical to a regular property. Is there a difference I am missing here?
- The try/catch change does not seem to change semantics either, unless there is a way this code could throw an exception:
```javascript
if (method === undefined) {
return Promise.resolve(undefined);
}
```
---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/streams/pull/490#issuecomment-237153605
Received on Wednesday, 3 August 2016 06:29:59 UTC