- From: Domenic Denicola <notifications@github.com>
- Date: Thu, 08 Oct 2015 08:50:23 -0700
- To: whatwg/fetch <fetch@noreply.github.com>
Received on Thursday, 8 October 2015 15:50:52 UTC
I really preferred the example before https://github.com/yutakahirano/fetch-with-streams/pull/58. It was more idiomatic promise usage and much clearer. The version in this PR is an example of the [explicit promise construction anti-pattern](http://stackoverflow.com/q/23803743/3191). But given that naive implementation of the promise spec currently causes the more idiomatic example to retain some memory for each chunk, maybe the proposed example is better since it avoids those issues in current implementations. I am a bit torn. Since @yutakahirano thinks this proposed version is better than I am OK with it. --- Reply to this email directly or view it on GitHub: https://github.com/whatwg/fetch/pull/138#issuecomment-146585549
Received on Thursday, 8 October 2015 15:50:52 UTC