- From: Domenic Denicola <notifications@github.com>
- Date: Wed, 07 Oct 2015 14:25:29 -0700
- To: whatwg/streams <streams@noreply.github.com>
- Message-ID: <whatwg/streams/pull/397@github.com>
This builds on the work @calvaris has done in in https://github.com/Igalia/streams/tree/webkit-tests/reference-implementation/webkit/reference-implementation, in many cases porting it directly over. Over time I hope that we can move all tests to this format. For now I have focused on those most urgent for Chrome's upcoming implementation, i.e., the readable stream and queuing strategy tests. I have deleted the original tests which have been ported over, so we can keep better track. This also adds a bit of new infrastructure to allow us to continue developing and testing the reference implementation inside Node.js, using `npm run wpt`. -- @tyoshino @calvaris I don't expect you guys to review this entire commit but if you could give it a quick spot check to see if it makes sense I'd appreciate it. BTW I thought about cleaning up the style of all the tests, to use more ES6, and to use promise_test and promise_rejects and stuff, but in the end I think it's better to just leverage @calvaris's work as-is instead of obsessing over test hygeine :). I'll probably do the templated and GC tests soon, before I try to get these in to Chrome. Also, @calvaris, should we be including some kind of license notice for your work? I know it was based on the CC0 tests here but you probably wrote it while employed by someone that requires licensing and stuff. I would imagine adding something like "portions are copyright WebKit MIT license blah blah blah" (or whatever the license for WebKit is) would probably be a good idea. You can view, comment on, or merge this pull request online at: https://github.com/whatwg/streams/pull/397 -- Commit Summary -- * Port a bunch of tests to web-platform-tests format -- File Changes -- M .travis.yml (2) M reference-implementation/README.md (16) M reference-implementation/package.json (6) A reference-implementation/run-web-platform-tests.js (25) M reference-implementation/test/bad-strategies.js (108) D reference-implementation/test/bad-underlying-sources.js (331) M reference-implementation/test/brand-checks.js (185) M reference-implementation/test/byte-length-queuing-strategy.js (74) M reference-implementation/test/count-queuing-strategy.js (275) D reference-implementation/test/readable-stream-cancel.js (248) M reference-implementation/test/readable-stream-reader.js (315) D reference-implementation/test/readable-stream-tee.js (216) M reference-implementation/test/readable-stream.js (773) A reference-implementation/web-platform-tests/byte-length-queuing-strategy.html (13) A reference-implementation/web-platform-tests/byte-length-queuing-strategy.js (109) A reference-implementation/web-platform-tests/count-queuing-strategy.html (13) A reference-implementation/web-platform-tests/count-queuing-strategy.js (106) A reference-implementation/web-platform-tests/readable-streams/bad-strategies.html (13) A reference-implementation/web-platform-tests/readable-streams/bad-strategies.js (115) A reference-implementation/web-platform-tests/readable-streams/bad-underlying-sources.html (13) A reference-implementation/web-platform-tests/readable-streams/bad-underlying-sources.js (377) A reference-implementation/web-platform-tests/readable-streams/brand-checks.html (14) A reference-implementation/web-platform-tests/readable-streams/brand-checks.js (136) A reference-implementation/web-platform-tests/readable-streams/cancel.html (14) A reference-implementation/web-platform-tests/readable-streams/cancel.js (260) A reference-implementation/web-platform-tests/readable-streams/count-queuing-strategy-integration.html (13) A reference-implementation/web-platform-tests/readable-streams/count-queuing-strategy-integration.js (177) A reference-implementation/web-platform-tests/readable-streams/general.html (14) A reference-implementation/web-platform-tests/readable-streams/general.js (817) A reference-implementation/web-platform-tests/readable-streams/readable-stream-reader.html (13) A reference-implementation/web-platform-tests/readable-streams/readable-stream-reader.js (333) A reference-implementation/web-platform-tests/readable-streams/tee.html (14) A reference-implementation/web-platform-tests/readable-streams/tee.js (305) A reference-implementation/web-platform-tests/resources/rs-utils.js (191) A reference-implementation/web-platform-tests/resources/test-utils.js (39) -- Patch Links -- https://github.com/whatwg/streams/pull/397.patch https://github.com/whatwg/streams/pull/397.diff --- Reply to this email directly or view it on GitHub: https://github.com/whatwg/streams/pull/397
Received on Wednesday, 7 October 2015 21:26:06 UTC