- From: Domenic Denicola <notifications@github.com>
- Date: Thu, 18 Jun 2015 10:08:07 -0700
- To: whatwg/streams <streams@noreply.github.com>
Received on Thursday, 18 June 2015 17:08:49 UTC
> @@ -1623,9 +1626,10 @@ a \[[stream]] internal slot. When a <code>WritableStream</code> error function < > 1. Resolve _writeRecord_.[[promise]] with *undefined*. > 1. DequeueValue(_stream_@[[queue]]). > 1. Let _syncResult_ be SyncWritableStreamStateWithQueue(_stream_). > - 1. If _syncResult_ is an abrupt completion, then return ErrorWritableStream(_stream_, _syncResult_.[[value]]). > - 1. Otherwise, return WritableStreamAdvanceQueue(_stream_). > - 1. Upon rejection of _writeResult_ with reason _r_, return ErrorWritableStream(_stream_, _r_). > + 1. If _syncResult_ is an abrupt completion, then perform ErrorWritableStream(_stream_, _syncResult_.[[value]]). Good catches both. For GetTotalQueueSize() and other operations with return values that we need to use, I am just going to omit the ReturnIfAbrupt. Maybe it would be better to do something like AssertNotAbrupt, but I think it is OK to just start using the value. Fixing and pushing. --- Reply to this email directly or view it on GitHub: https://github.com/whatwg/streams/pull/366/files#r32753118
Received on Thursday, 18 June 2015 17:08:49 UTC