Re: [ServiceWorker] Add cookie accessor/setter methods? (#707)

@RReverser 

> 1) Shouldn't be `Cookie.name` `Readonly`?

Is there any benefit in:

```js
navigator.cookies.get('hello').then(cookie => {
  cookie.value += ' foobar';
  return navigator.cookies.set(cookie);
});
```

…if not, all cookie properties should be `readonly`.

> 2) What is the purpose of `USVString name` parameter in `getAll()`? Aren't names unique?

Copy/paste error, sorry!

> 3) If yes is the answer to both above, maybe we can do `Promise<Map<string, Cookie>> getAll()`?

Interesting. If we're going to remove `name` from `Cookie` it may be better to remove `getAll` and go with `cookies.keys()` which returns an array of cookie names, which you can get with `.get` if you need to.

---
Reply to this email directly or view it on GitHub:
https://github.com/slightlyoff/ServiceWorker/issues/707#issuecomment-110326225

Received on Tuesday, 9 June 2015 11:33:06 UTC