- From: Peter Beverloo <notifications@github.com>
- Date: Tue, 07 Jul 2015 08:39:46 -0700
- To: w3c/push-api <push-api@noreply.github.com>
Received on Tuesday, 7 July 2015 15:40:39 UTC
Overall SGTM, pending the on-going discussion about the curve to use. We're experimenting with `curve25519dh` following the semantics of the PR. Something to consider for a follow-up: giving authors the ability to explicitly rotate their keys, e.g. `PushSubscription.prototype.rotateKeys()`. This would allow them to avoid creating an entirely new subscription in case it's just the keys they'd like to change. --- Reply to this email directly or view it on GitHub: https://github.com/w3c/push-api/pull/130#issuecomment-119242198
Received on Tuesday, 7 July 2015 15:40:39 UTC