- From: Domenic Denicola <notifications@github.com>
- Date: Fri, 16 Jan 2015 16:45:25 -0800
- To: whatwg/streams <streams@noreply.github.com>
- Message-ID: <whatwg/streams/pull/265@github.com>
Fixes #256 (/cc @jkrems).
Could use some careful review as the changes were pretty wide-ranging. I am not too worried about the algorithms---the reference implementation and its extensive test suite help with my confidence there---but the editorial changes always leave the potential for pointers, "dead code", etc.
Preview at https://streams.spec.whatwg.org/branch-snapshots/first-class-source-sink-objects/
You can view, comment on, or merge this pull request online at:
https://github.com/whatwg/streams/pull/265
-- Commit Summary --
* Call underlying source functions as methods
* Call underlying sink functions as methods.
* Add tests for the new source/sink error cases
-- File Changes --
M index.bs (369)
M reference-implementation/lib/helpers.js (46)
M reference-implementation/lib/readable-stream-abstract-ops.js (49)
M reference-implementation/lib/readable-stream.js (35)
M reference-implementation/lib/writable-stream.js (72)
A reference-implementation/test/bad-underlying-sinks.js (314)
A reference-implementation/test/bad-underlying-sources.js (239)
M reference-implementation/test/readable-stream.js (31)
M reference-implementation/test/writable-stream-abort.js (12)
M reference-implementation/test/writable-stream.js (38)
-- Patch Links --
https://github.com/whatwg/streams/pull/265.patch
https://github.com/whatwg/streams/pull/265.diff
---
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/streams/pull/265
Received on Saturday, 17 January 2015 00:45:52 UTC