- From: Takeshi Yoshino <notifications@github.com>
- Date: Mon, 05 Jan 2015 21:05:48 -0800
- To: whatwg/streams <streams@noreply.github.com>
Received on Tuesday, 6 January 2015 05:06:19 UTC
Took a look at `Locking Design Doc.md`. Almost all of the rationale looks good to me. I agree that there's no compelling reason for exposing stream.isLocked, yet. `lock.isActive` looks useful as Yutaka said (https://github.com/whatwg/streams/issues/241#issuecomment-65218999) but I also wonder if there's any concrete use case where this is required (not just useful). `releaseLock()` maybe to make it more descriptive, you've included `Lock`. Right? Just `release()` would have any problem? Even after release, reader's `closed`, `ready`, and `state` getters will simply delegate to the encapsulated stream as the note at https://streams.spec.whatwg.org/#reader-release-lock explains. I don't have strong opinion yet but wonder if this is useful or harmful. --- Reply to this email directly or view it on GitHub: https://github.com/whatwg/streams/issues/241#issuecomment-68826690
Received on Tuesday, 6 January 2015 05:06:19 UTC