- From: Takeshi Yoshino <notifications@github.com>
- Date: Wed, 04 Feb 2015 07:44:39 -0800
- To: whatwg/streams <streams@noreply.github.com>
Received on Wednesday, 4 February 2015 15:45:34 UTC
Domenic. Had a look at your change. It's nice work but as Yutaka pointed out, it's revealing the internal state. This issue made me rethink the whole architecture. We gave up a lot recently such as that the reader can be used for stream subclasses, etc. It looks the current implementation is twisted for no longer valid requirements. I made a PR #277 which uses a lot of interaction on hidden variables between the stream and reader but realizes the promise identity requirement perfectly (i.e. the ideal stability in https://github.com/whatwg/streams/issues/266#issuecomment-72658409). Do you think this violates any of still-valid design requirements? --- Reply to this email directly or view it on GitHub: https://github.com/whatwg/streams/issues/266#issuecomment-72877745
Received on Wednesday, 4 February 2015 15:45:34 UTC