- From: Domenic Denicola <notifications@github.com>
- Date: Thu, 03 Dec 2015 12:48:18 -0800
- To: whatwg/streams <streams@noreply.github.com>
- Message-ID: <whatwg/streams/issues/411/161780227@github.com>
@youennf > I was wondering whether you were planning to move all those tests at some point to W3C web-platform-tests repo? If so, do you have any special schedule? That's definitely the plan. The tests have lived here historically because they evolve in concert with the spec, and I like being able to make changes in a single commit. But, maybe these parts of the spec have stabilized enough that I should upstream them and stop maintaining a copy here. Maybe one way to allow me to maintain my workflow would be for web-platform-tests to have a submodule dependency on whatwg/streams? But, maybe that is too much special-casing just for me, and could cause problems for other tools like e.g. the Mozilla tooling @wanderview mentions. On the other hand, I think more specs should adopt this workflow of committing changes to the tests in the same commit as the spec changes, so a submodules approach could help us with that world. I dunno. In any case, I don't have a specific timeline. > Also, the current html tests are running regular tests, tests in worker, tests in shared worker and tests in service worker. Would it be possible to split them in xx.html, xx-worker.html, xx-sharedworker.html...? If that is ok, I can take over that editing. I agree with the others that this would be a lot of work, and so I'd prefer the current form. I'd actually prefer if web platform tests took over this work for me, like they already do with .worker.js files... the boilerplate and duplication (e.g. between `<script>`s in .html + `if`-guarded `importScript`s in the .js) is annoying. One issue right now is that I am getting warnings from testharness about how the tests all have the same name. That is, the worker tests and service worker tests and shared worker tests and non-worker tests all just call `test(..., 'name')` so when you run them all together you get four tests with the same name. I am not sure what the right way to fix this is. Maybe @jgraham has some ideas. @wanderview > I could get these tests into wpt repo as one of my first tasks. Less work for me! Sounds great :) --- Reply to this email directly or view it on GitHub: https://github.com/whatwg/streams/issues/411#issuecomment-161780227
Received on Thursday, 3 December 2015 20:48:47 UTC