- From: Jungkee Song <notifications@github.com>
- Date: Tue, 01 Dec 2015 22:10:23 -0800
- To: slightlyoff/ServiceWorker <ServiceWorker@noreply.github.com>
Received on Wednesday, 2 December 2015 06:10:53 UTC
In reflection, I think we should stay with the current `.navigate()` as-is. (i.e. not allowing navigations of off-scope clients regardless what maxScope was set). Suppose setting a maxScope in the header to `https://www.stanford.edu/` but setting the effective scope to `https://www.stanford.edu/~username/`. Then, `matchAll({ includeUncontrolled:true })` will still return a client with `https://www.stanford.edu/`. Navigation of that client should NOT be allowed, right? Also, returning all the clients in the origin from `matchAll({ includeUncontrolled:true })` and rejecting on the actual operations on off-scope clients sound more reasonable to me. (due to the reason here: https://github.com/slightlyoff/ServiceWorker/issues/428#issuecomment-53413333) `.navigate()` currently does so. WDYT? (Note that `.focus()` and `.postMessage()` are NOT filtering off-scope clients now. Is that what we wanted?) --- Reply to this email directly or view it on GitHub: https://github.com/slightlyoff/ServiceWorker/issues/752#issuecomment-161190360
Received on Wednesday, 2 December 2015 06:10:53 UTC