- From: <bugzilla@jessica.w3.org>
- Date: Thu, 14 Aug 2014 11:51:53 +0000
- To: public-webapps-bugzilla@w3.org
https://www.w3.org/Bugs/Public/show_bug.cgi?id=26568 --- Comment #10 from Philip Jägenstedt <philipj@opera.com> --- I've tried implementing the change and it looks good. A test regression caused by this is when requesting fullscreen twice on the same element. Previously it would fire a fullscreenerror event, now it does nothing, so anyone waiting for an event will wait forever. I'm not sure if it's a real-world problem, but it would be nice if a call to requestFullscreen() always resulted in an event. Nit: Can an element have a browsing context? Everywhere else in the spec it's documents which have them, and that's also where I have to get it from in Blink. Nit 2: Rephrase the last point to something that always evaluates to true or false, as opposed to an if with no else branch? -- You are receiving this mail because: You are the QA Contact for the bug.
Received on Thursday, 14 August 2014 11:51:54 UTC