- From: csswg-test-issue-mover <web-platform-tests-notifications@w3.org>
- Date: Fri, 31 Mar 2017 13:11:27 GMT
- To: public-web-platform-tests-notifications@w3.org
Originally posted as https://github.com/w3c/csswg-test/pull/1196#issuecomment-289350818 by @frivoal on 27 Mar 2017, 04:22 UTC: > @fantasai fixes based on the review are done. Ready for next round. > > I've reworded the text instructions in -018 and -019, hopefully the problem you had with them are gone now. > > I've been through the green square tests, and reworked quite a few of them. > > I think the worst offender was by far the first one (-006), so I've made it into a much simpler test with a different reference. > > For most of the other tests, It seemed to me that what made them hard to understand was not so much trying to make them match the standard green square, but the way I was doing it, applying a whole bunch of properties onto a single element, leaving the reviewer with quite a puzzle trying to figure out how it all fits together. I've rewritten them by separating out the various part (the thing that makes a green backdrop, the thing that may turn red on top of it if the test fails...), making it hopefully much clearer and easier to work with, still matching the green square. Hopefully you agree that it is not ok. If not, I'll need more detailed coaching about why it's not. View on GitHub: https://github.com/w3c/web-platform-tests/pull/5285#issuecomment-290707889
Received on Friday, 31 March 2017 13:11:43 UTC